Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

named logical vector in i now selects expected row. Closes #2152 #2213

Merged
merged 3 commits into from
Jun 30, 2017

Conversation

jangorecki
Copy link
Member

@jangorecki jangorecki commented Jun 22, 2017

Unfortunately named TRUE will not return true when passed to isTRUE(c(foo=TRUE)) therefore unname() has been added in check condition. Also closes duplicate report #2210.
CI failures seems to be related to fwrite, not this PR.

@codecov-io
Copy link

codecov-io commented Jun 30, 2017

Codecov Report

Merging #2213 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2213      +/-   ##
==========================================
+ Coverage    90.7%   90.74%   +0.04%     
==========================================
  Files          59       59              
  Lines       11509    11510       +1     
==========================================
+ Hits        10439    10445       +6     
+ Misses       1070     1065       -5
Impacted Files Coverage Δ
R/data.table.R 97.45% <100%> (ø) ⬆️
src/rbindlist.c 88.93% <0%> (+0.19%) ⬆️
src/forder.c 94.47% <0%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d53179e...6e38d30. Read the comment docs.

@mattdowle mattdowle merged commit 41f8d6f into master Jun 30, 2017
@mattdowle mattdowle deleted the named_logical_subset_2152 branch June 30, 2017 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants